Review the change, not the person
Omar reviews Yassine's Pull Request. He checks the task, the code difference and the observed behavior.
A simple review asks:
- Does the change solve the stated issue?
- Are unrelated files included?
- Is the code understandable?
- Does the interface still work with keyboard and mobile use?
- Did automated checks pass?
Checks can run linting, tests or a build. A green check is useful evidence, but it does not prove that the feature satisfies the requirement. Human review still matters.
Write useful feedback
Useful:
The link works with the mouse, but keyboard focus is not visible.
Could we preserve the existing focus style here?
Not useful:
Bad code.
Feedback should identify the observation and the expected improvement.
Merge only accepted work
When feedback is resolved and required checks pass, the team merges the Pull Request on GitHub. Merge means the accepted changes enter main.
After the merge, delete the remote feature branch. The branch served one task and is now finished.
Update the local project:
git switch main
git pull
git branch -d feature/add-contact-link
-d refuses to delete a branch Git considers unmerged locally. This is safer for beginners than forcing deletion. Pull the merged main before cleaning up.
Know each action
Approve = reviewer accepts the proposal
Merge = changes enter main
Delete = finished branch name is removed
Pull = local main receives the merged work
What to remember
Review checks the requirement, the difference and the evidence. Merge changes shared history. After merging, update local main and remove the short-lived branch.